netdev - Re: [RFC PATCH 0/5] net: low latency Ethernet device polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5134592E.6050508@linux.intel.com>
Date:	Mon, 04 Mar 2013 10:19:58 +0200
From:	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
CC:	Eliezer Tamir <eliezer.tamir@...ux.jf.intel.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Dave Miller <davem@...emloft.net>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	e1000-devel@...ts.sourceforge.net,
	Willem de Bruijn <willemb@...gle.com>,
	Andi Kleen <andi@...stfloor.org>, HPA <hpa@...or.com>,
	Eliezer Tamir <eliezer@...ir.org.il>
Subject: Re: [RFC PATCH 0/5] net: low latency Ethernet device polling


On 04/03/2013 09:37, Cong Wang wrote:
> On 02/28/2013 01:55 AM, Eliezer Tamir wrote:
>>
>> Open issues:
>> 1. Find a way to avoid the need to change the sk and skb structs.
>> One big disadvantage of how we do this right now is that when a device is
>> removed, it's hard to prevent it from getting polled by a socket
>> which holds a stale reference.
>>
>> 2. How do we decide which sockets are eligible to do busy polling?
>> Do we add a socket option to control this?
>> How do we provide sane defaults while allowing flexibility and
>> performance?
>>
>> 3. Andi Kleen and HPA pointed out that using get_cycles() is not
>> portable.
>>
>> 4. How and where do we call ndo_ll_poll from the socket code?
>> One good place seems to be wherever the kernel puts the process to sleep,
>> waiting for more data, but this makes doing something intelligent about
>> poll (the system call) hard. From the perspective of how ndo_ll_poll
>> itself is implemented this does not seem to matter.
>>
>> 5. I would like to hear suggestions on naming conventions and where
>> to put the code that for now I have put in include/net/ll_poll.h
>>
>
>
> A dumb question: is bypassing tcpdump/netfilters/qdisc etc. what we
> always want? Isn't this a security issue?

We are not bypassing any of the regular stack checks/hooks, we call the 
normal netif_rx_skb().

Thanks,
Eliezer
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html