netdev - Re: [PATCH] 8139too: send NETDEV_CHANGE manually when autoneg is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130306.155323.344491888348815531.davem@davemloft.net>
Date:	Wed, 06 Mar 2013 15:53:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	vfalico@...hat.com, netdev@...r.kernel.org, wfp5p@...ginia.edu,
	jasowang@...hat.com, junchangwang@...il.com,
	greearb@...delatech.com, ivecera@...hat.com
Subject: Re: [PATCH] 8139too: send NETDEV_CHANGE manually when autoneg is
 disabled

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 6 Mar 2013 20:22:52 +0000

> On Wed, 2013-03-06 at 20:06 +0100, Veaceslav Falico wrote:
>> When setting autoneg off (with any additional parameters, like
>> speed/duplex), 8139too doesn't do an interface reset, and thus doesn't
>> notify anyone that its speed/duplex might have changed (bonding and bridge
>> will not see the speed changes, per example).
>>
>> Verify if we've force_media and send notification manually, so that the
>> listeners have a chance to see the changes. It's quite ugly, however I
>> don't see anything better.
> 
> Isn't this really a bug in mii_check_media()?  It shouldn't shortcut the
> calls to netif_carrier_{off,on}() just because mii->force_media is set.

I think mii_check_media() is responsible for handling this too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html