netdev - Re: [PATCH] 8139too: send NETDEV_CHANGE manually when autoneg is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130306213511.GA11331@electric-eye.fr.zoreil.com>
Date:	Wed, 6 Mar 2013 22:35:11 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	David Miller <davem@...emloft.net>
Cc:	bhutchings@...arflare.com, vfalico@...hat.com,
	netdev@...r.kernel.org, wfp5p@...ginia.edu, jasowang@...hat.com,
	junchangwang@...il.com, greearb@...delatech.com, ivecera@...hat.com
Subject: Re: [PATCH] 8139too: send NETDEV_CHANGE manually when autoneg is disabled

David Miller <davem@...emloft.net> :
> From: Ben Hutchings <bhutchings@...arflare.com>
[...]
> > Isn't this really a bug in mii_check_media()?  It shouldn't shortcut the
> > calls to netif_carrier_{off,on}() just because mii->force_media is set.
> 
> I think mii_check_media() is responsible for handling this too.

There are a few drivers that use mii_ethtool_sset as 8139too does
while not relying upon mii_check_media.

What ought to be done for those ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html