netdev - Re: [PATCH BUGFIX 0/6] pkt_sched: fix little service anomalies and possible crashes of qfq+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130305.235006.1904081547083683406.davem@davemloft.net>
Date:	Tue, 05 Mar 2013 23:50:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	paolo.valente@...more.it
Cc:	jhs@...atatu.com, shemminger@...tta.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, fchecconi@...il.com,
	rizzo@....unipi.it
Subject: Re: [PATCH BUGFIX 0/6] pkt_sched: fix little service anomalies and
 possible crashes of qfq+

From: Paolo valente <paolo.valente@...more.it>
Date: Tue,  5 Mar 2013 19:04:56 +0100

> Split, and inserted a detailed description of both the problem and the fix
> in each patch.

Series applied, thanks.

Although two topics for possibly resolving later:

1) That 1ULL bit mask fix is quite expensive on 32-bit, it would
   probably be cheaper to test for that case using a helper function
   that nops out on 64-bit.  Although this is not so important.

2) That static inline forward declaration is ugly, better to remove
   the inline tag (let the compiler handle it) or move the function
   above all the call sites.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html