netdev - Re: [PATCH 1/2] benet: Wait f/w POST until timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130305.235836.1815836004691126948.davem@davemloft.net>
Date:	Tue, 05 Mar 2013 23:58:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Sathya.Perla@...lex.Com
Cc:	shangw@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	subbu.seetharaman@...lex.com, Ajit.Khaparde@...lex.Com
Subject: Re: [PATCH 1/2] benet: Wait f/w POST until timeout

From: "Perla, Sathya" <Sathya.Perla@...lex.Com>
Date: Wed, 6 Mar 2013 04:45:03 +0000

>> -----Original Message-----
>> From: David Miller [mailto:davem@...emloft.net]
>> 
>> From: Gavin Shan <shangw@...ux.vnet.ibm.com>
>> Date: Mon,  4 Mar 2013 15:48:46 +0800
>> 
>> > While PCI card faces EEH errors, reset (usually hot reset) is expected
>> > to recover from the EEH errors. After EEH core finishes the reset, the
>> > driver callback (be_eeh_reset) is called and wait the firmware to
>> > complete POST successfully. The original code would return with error
>> > once detecting failure during POST stage. That seems not enough.
>> >
>> > The patch forces the driver (be_eeh_reset) to wait the firmware
>> > completes POST until timeout, instead of returning error upon
>> > detection POST failure immediately. Also, it would improve the
>> > reliability of the EEH funtionality of the driver.
>> >
>> > Signed-off-by: Gavin Shan <shangw@...ux.vnet.ibm.com>
>> 
>> I know that patch #2 of this series needs to be implemented differently, but this
>> patch seems fine.
>> 
>> So can I get an ACK from one of the benet driver folks?
> 
> Acked-by: Sathya Perla <sathya.perla@...lex.com>

Applied, thanks for reviewing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html