netdev - Re: [PATCH] net: ethernet: cpsw: fix usage of cpdma_check_free_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130313.045150.2214781310963907722.davem@davemloft.net>
Date:	Wed, 13 Mar 2013 04:51:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	andreas.fenkart@...eamunlimited.com
Cc:	mugunthanvnm@...com, zonque@...il.com, netdev@...r.kernel.org,
	s.neumann@...mfeld.com, koen@...inion.thruhere.net
Subject: Re: [PATCH] net: ethernet: cpsw: fix usage of
 cpdma_check_free_tx_desc()

From: Andreas Fenkart <andreas.fenkart@...eamunlimited.com>
Date: Tue, 12 Mar 2013 21:20:27 +0100

> On Wed, Mar 13, 2013 at 01:17:44AM +0530, Mugunthan V N wrote:
>> On 3/12/2013 10:01 PM, Daniel Mack wrote:
>> >Commit fae50823d0 ("net: ethernet: davinci_cpdma: Add boundary for rx
>> >and tx descriptors") introduced a function to check the current
>> >allocation state of tx packets. The return value is taken into account
>> >to stop the netqork queue on the adapter in case there are no free
>> >slots.
>> >
>> >However, cpdma_check_free_tx_desc() returns 'true' if there is room in
>> >the bitmap, not 'false', so the usage of the function is wrong.
>> >
>> >Signed-off-by: Daniel Mack <zonque@...il.com>
>> >Cc: Mugunthan V N <mugunthanvnm@...com>
>> >Reported-by: Sven Neumann <s.neumann@...mfeld.com>
>> >Reported-by: Andreas Fenkart <andreas.fenkart@...eamunlimited.com>
...
>> Tested-by: Mugunthan V N <mugunthanvnm@...com>
>> Acked-by: Mugunthan V N <mugunthanvnm@...com>
 ...
> This restores throughput to the level of 3.7.0
> 
> Tested-by: Andreas Fenkart <andreas.fenkart@...eamunlimited.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html