netdev - Re: [PATCH] bonding: don't call update_speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130313.045336.984924610426807326.davem@davemloft.net>
Date:	Wed, 13 Mar 2013 04:53:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, lkml@...nx.org, eric.dumazet@...il.com,
	fubar@...ibm.com, jeffrey.t.kirsher@...el.com,
	xiyou.wangcong@...il.com, andy@...yhouse.net
Subject: Re: [PATCH] bonding: don't call update_speed_duplex() under
 spinlocks

From: Veaceslav Falico <vfalico@...hat.com>
Date: Tue, 12 Mar 2013 17:31:32 +0100

> bond_update_speed_duplex() might sleep while calling underlying slave's
> routines. Move it out of atomic context in bond_enslave() and remove it
> from bond_miimon_commit() - it was introduced by commit 546add79, however
> when the slave interfaces go up/change state it's their responsibility to
> fire NETDEV_UP/NETDEV_CHANGE events so that bonding can properly update
> their speed.
> 
> I've tested it on all combinations of ifup/ifdown, autoneg/speed/duplex
> changes, remote-controlled and local, on (not) MII-based cards. All changes
> are visible.
> 
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html