netdev - Re: [iproute2] Fix -oneline output when alias present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130313094859.GA3097@amd64.fatal.se>
Date:	Wed, 13 Mar 2013 10:48:59 +0100
From:	Andreas Henriksson <andreas@...al.se>
To:	roopa@...ulusnetworks.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [iproute2] Fix -oneline output when alias present

Hi!

Just wanted to point out some minor style issues with your patch.
See below...

On Tue, Mar 12, 2013 at 12:03:47PM -0000, roopa@...ulusnetworks.com wrote:
[...]
> -	if (do_link && tb[IFLA_IFALIAS])
> -		fprintf(fp,"\n    alias %s", 
> +	if (do_link && tb[IFLA_IFALIAS]) {
> +		fprintf(fp, "%s", _SL_);
> +		fprintf(fp,"    alias %s",

                          ^^^ missing space here.

Also, why not use a single fprintf?

Like:
                fprintf(fp, "%s    alias %s",
                        _SL_,
>  			rta_getattr_str(tb[IFLA_IFALIAS]));
> +	}

Then you wouldn't need these brackets either...

>  
>  	if (do_link && show_stats) {
>  		if (tb[IFLA_STATS64])

-- 
Andreas Henriksson
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html