netdev - Re: [iproute2] Fix -oneline output when alias present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51406EF8.5000506@cumulusnetworks.com>
Date:	Wed, 13 Mar 2013 05:20:08 -0700
From:	Roopa Prabhu <roopa@...ulusnetworks.com>
To:	Andreas Henriksson <andreas@...al.se>
CC:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [iproute2] Fix -oneline output when alias present

On 3/13/13 2:48 AM, Andreas Henriksson wrote:
> Hi!
>
> Just wanted to point out some minor style issues with your patch.
> See below...
>
> On Tue, Mar 12, 2013 at 12:03:47PM -0000, roopa@...ulusnetworks.com wrote:
> [...]
>> -	if (do_link&&  tb[IFLA_IFALIAS])
>> -		fprintf(fp,"\n    alias %s",
>> +	if (do_link&&  tb[IFLA_IFALIAS]) {
>> +		fprintf(fp, "%s", _SL_);
>> +		fprintf(fp,"    alias %s",
>
>                            ^^^ missing space here.

Oh, I hadn't noticed that. I did not introduce the style problem there.
I just happened to pick the _SL_line from else where in the code.
Since this patch is in, I will submit a patch to fix the spacing.
>
> Also, why not use a single fprintf?

I was just following convention here. The SL line seems to be on a line 
of its own else where in the code. Which i did think was cleaner.


Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html