netdev - Re: [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130313.103830.247889330240632952.davem@davemloft.net>
Date:	Wed, 13 Mar 2013 10:38:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	poettner@....cs.tu-bs.de
Cc:	Linux-zigbee-devel@...ts.sourceforge.net,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/ieee802154/6lowpan: Fix initialization for
 fragment offset

From: Wolf-Bastian Pöttner <poettner@....cs.tu-bs.de>
Date: Wed, 13 Mar 2013 08:50:54 +0100

> offset has to be initialized, otherwise the *first* fragment will
> be discarded and reassembly cannot happen.
> 
> Reviewed-by: Alan Ott <alan@...nal11.us>

'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset)
succeeds, in which case it will be initialized properly.  Otherwise we
unlock and drop the SKB and make no references whatsoever to 'offset'.

I suspect you saw some compiler warning about 'offset' being
uninitialized, and are just blindly trying to shut this warning up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html