netdev - Re: [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D859EF9A-19A9-4F74-B59D-28FADBCE338A@ibr.cs.tu-bs.de>
Date:	Wed, 13 Mar 2013 15:40:06 +0100
From:	Wolf-Bastian Pöttner <poettner@....cs.tu-bs.de>
To:	David Miller <davem@...emloft.net>
Cc:	Linux-zigbee-devel@...ts.sourceforge.net,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset

Hi!


Nope. The patch fixes a problem in code that is not in mainline yet. However, people on the linux-zigbee mailing list found it a good idea to commit this change to mainline to avoid the problem from arising.

I see, you disagree. Nevermind. ;)


Bastian
-- 
Wolf-Bastian Pöttner      Institut für Betriebssysteme & Rechnerverbund
Tel.: +49-531-391-3265                           Mühlenpfordtstrasse 23
Fax.: +49-531-391-5936         TU Braunschweig     D-38106 Braunschweig

Am 13.03.2013 um 15:38 schrieb David Miller <davem@...emloft.net>:

> From: Wolf-Bastian Pöttner <poettner@....cs.tu-bs.de>
> Date: Wed, 13 Mar 2013 08:50:54 +0100
> 
>> offset has to be initialized, otherwise the *first* fragment will
>> be discarded and reassembly cannot happen.
>> 
>> Reviewed-by: Alan Ott <alan@...nal11.us>
> 
> 'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset)
> succeeds, in which case it will be initialized properly.  Otherwise we
> unlock and drop the SKB and make no references whatsoever to 'offset'.
> 
> I suspect you saw some compiler warning about 'offset' being
> uninitialized, and are just blindly trying to shut this warning up.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html