netdev - Re: [PATCH] tcp: fix skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130314.115127.1235077957822193794.davem@davemloft.net>
Date:	Thu, 14 Mar 2013 11:51:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, quiche@...omium.org
Subject: Re: [PATCH] tcp: fix skb_availroom()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 14 Mar 2013 16:40:32 +0100

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Chrome OS team reported a crash on a Pixel ChromeBook in TCP stack :
> 
> https://code.google.com/p/chromium/issues/detail?id=182056
> 
> commit a21d45726acac (tcp: avoid order-1 allocations on wifi and tx
> path) did a poor choice adding an 'avail_size' field to skb, while
> what we really needed was a 'reserved_tailroom' one.
> 
> It would have avoided commit 22b4a4f22da (tcp: fix retransmit of
> partially acked frames) and this commit.
> 
> Crash occurs because skb_split() is not aware of the 'avail_size'
> management (and should not be aware)
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Mukesh Agrawal <quiche@...omium.org>

Applied and queued up for -stable, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html