netdev - Re: [PATCH] skb: Propagate pfmemalloc on skb from head page only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130314.115441.1016076054622568752.davem@davemloft.net>
Date:	Thu, 14 Mar 2013 11:54:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	xemul@...allels.com, mgorman@...e.de, netdev@...r.kernel.org,
	stable@...nel.org, kuznet@....inr.ac.ru
Subject: Re: [PATCH] skb: Propagate pfmemalloc on skb from head page only

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 14 Mar 2013 15:16:09 +0100

> On Thu, 2013-03-14 at 17:29 +0400, Pavel Emelyanov wrote:
>> Hi.
>> 
>> I'm trying to send big chunks of memory from application address space via
>> TCP socket using vmsplice + splice like this
>> 
>>    mem = mmap(128Mb);
>>    vmsplice(pipe[1], mem); /* splice memory into pipe */
>>    splice(pipe[0], tcp_socket); /* send it into network */
>> 
>> When I'm lucky and a huge page splices into the pipe and then into the socket
>> _and_ client and server ends of the TCP connection are on the same host,
>> communicating via lo, the whole connection gets stuck! The sending queue
>> becomes full and app stops writing/splicing more into it, but the receiving
>> queue remains empty, and that's why.
>> 
>> The __skb_fill_page_desc observes a tail page of a huge page and erroneously
>> propagates its page->pfmemalloc value onto socket (the pfmemalloc on tail pages
>> contain garbage). Then this skb->pfmemalloc leaks through lo and due to the
>> 
>>     tcp_v4_rcv
>>     sk_filter
>>         if (skb->pfmemalloc && !sock_flag(sk, SOCK_MEMALLOC)) /* true */
>>             return -ENOMEM
>>         goto release_and_discard;
>> 
>> no packets reach the socket. Even TCP re-transmits are dropped by this, as skb
>> cloning clones the pfmemalloc flag as well.
>> 
>> That said, here's the proper page->pfmemalloc propagation onto socket: we
>> must check the huge-page's head page only, other pages' pfmemalloc and mapping
>> values do not contain what is expected in this place. However, I'm not sure
>> whether this fix is _complete_, since pfmemalloc propagation via lo also 
>> oesn't look great.
>> 
>> Both, bit propagation from page to skb and this check in sk_filter, were 
>> introduced by c48a11c7 (netvm: propagate page->pfmemalloc to skb), in v3.5 so
>> Mel and stable@ are in Cc.
>> 
>> Signed-off-by: Pavel Emelyanov <xemul@...allels.com>
 ...
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html