netdev - Re: [patch] RxRPC: use copy_to_user() instead of memcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130319225101.GZ9189@mwanda>
Date:	Wed, 20 Mar 2013 01:51:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	David Howells <dhowells@...hat.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] RxRPC: use copy_to_user() instead of memcpy()

Thanks for the explanation.  I misread the code and then managed to
trigger an unrelated locking bug and got confused.

I think there is a spin_unlock(call->lock) missing somewhere on an
error path.  I have attached a reproducer file.

regards,
dan carpenter

View attachment "test_rxrpc.c" of type "text/x-csrc" (7272 bytes)