netdev - Re: [patch] RxRPC: use copy_to_user() instead of memcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27098.1363775018@warthog.procyon.org.uk>
Date:	Wed, 20 Mar 2013 10:23:38 +0000
From:	David Howells <dhowells@...hat.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	dhowells@...hat.com, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] RxRPC: use copy_to_user() instead of memcpy()

Dan Carpenter <dan.carpenter@...cle.com> wrote:

> Thanks for the explanation.  I misread the code and then managed to
> trigger an unrelated locking bug and got confused.
> 
> I think there is a spin_unlock(call->lock) missing somewhere on an
> error path.  I have attached a reproducer file.

Are you running with lockdep enabled?  That should catch such things.

David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html