netdev - Re: [PATCH v2 1/4] tcp: fix too short FIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130319.093257.1744500513624729643.davem@davemloft.net>
Date:	Tue, 19 Mar 2013 09:32:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	makita.toshiaki@....ntt.co.jp
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/4] tcp: fix too short FIN_WAIT2 time out

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Mon, 18 Mar 2013 21:39:04 +0900

>  		if (tp->linger2 >= 0) {
> -			const int tmo = tcp_fin_time(sk) - TCP_TIMEWAIT_LEN;
> -
> -			if (tmo > 0) {
> -				tcp_time_wait(sk, TCP_FIN_WAIT2, tmo);
> -				goto out;
> -			}
> +			tcp_time_wait(sk, TCP_FIN_WAIT2, TCP_TIMEWAIT_LEN);
> +			goto out;
>  		}

Well, now you're completely ignoring the user's linger setting.

I really can't take these patches seriously, and will not apply them,
sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html