netdev - Re: [PATCH v2 1/4] tcp: fix too short FIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1363866317.3029.21.camel@ubuntu-vm-makita>
Date:	Thu, 21 Mar 2013 20:45:17 +0900
From:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	makita.toshiaki@....ntt.co.jp
Subject: Re: [PATCH v2 1/4] tcp: fix too short FIN_WAIT2 time out

On Tue, 2013-03-19 at 09:32 -0400, David Miller wrote:
> From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Date: Mon, 18 Mar 2013 21:39:04 +0900
> 
> >               if (tp->linger2 >= 0) {
> > -                     const int tmo = tcp_fin_time(sk) - TCP_TIMEWAIT_LEN;
> > -
> > -                     if (tmo > 0) {
> > -                             tcp_time_wait(sk, TCP_FIN_WAIT2, tmo);
> > -                             goto out;
> > -                     }
> > +                     tcp_time_wait(sk, TCP_FIN_WAIT2, TCP_TIMEWAIT_LEN);
> > +                     goto out;
> >               }
> 
> Well, now you're completely ignoring the user's linger setting.

If you mention TCP_LINGER2, I don't think I'm ignoring it.
It is taken into account in tcp_rcv_state_process() or tcp_close().
If I'm misunderstanding, I'd be glad if you could point out it.

> 
> I really can't take these patches seriously, and will not apply them,
> sorry.

I think, at least, too short timeout is harmful.
If tcp_fin_timeout is set to 61, it will expire in 2 seconds, which
cause peer to receive unexpected reset by sending fin.
Don't you think there is a problem?

Toshiaki Makita

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html