netdev - Re: [PATCH 2/2] sh_eth: check TSU registers ioremap() error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <514A11E9.1070708@cogentembedded.com>
Date:	Wed, 20 Mar 2013 22:45:45 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Denis Kirjanov <kda@...ux-powerpc.org>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	nobuhiro.iwamatsu.yj@...esas.com
Subject: Re: [PATCH 2/2] sh_eth: check TSU registers ioremap() error

Hello.

On 03/20/2013 09:20 PM, Denis Kirjanov wrote:

> It doesn't make sense to worry about branch misprediction during probe() :)

     You misunderstood. I didn't mean using unlikely() at all, just that 
the ioremap() failure is unlikely.


PS: Please, don't top post.

> On 3/20/13, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
>> On 03/20/2013 10:04 PM, Sergei Shtylyov wrote:
>>
>>>>> One must check the result of ioremap() -- in this case it prevents
>>>>> potential
>>>>> kernel oops when initializing TSU registers further on...
>>>>>
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>>> Applied and queued up for -stable.
>>>     Thanks. However, do you really think it's needed in stable? It's
>>> only error path, after all...
>>      I forgot to add "unlikely" to the "error path". I usually don't mark
>> such patches for stable, when I'm not in a hurry. :-)
>>

WBR, Sergei



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html