netdev - Re: [PATCH] chelsio: use netdev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363805095.3333.30.camel@edumazet-glaptop>
Date:	Wed, 20 Mar 2013 11:44:55 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] chelsio: use netdev_alloc_skb

On Wed, 2013-03-20 at 11:30 -0700, Stephen Hemminger wrote:

> -		skb = alloc_skb(len + 2, GFP_ATOMIC);
> +		skb = netdev_alloc_skb_ip_align(netdev, len + 2);
>  		if (!skb)
>  			goto use_orig_buf;
>  


If you use the helper, no need for 'len + 2' but :

netdev_alloc_skb_ip_align(netdev, len);



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html