| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1363799443.2677.2.camel@bwh-desktop.uk.solarflarecom.com> Date: Wed, 20 Mar 2013 17:10:43 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: tingwei liu <tingw.liu@...il.com>, <netdev@...r.kernel.org>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, <davem@...emloft.net> Subject: Re: [PATCH 1/1]core:Change a wrong explain about dev_get_by_name On Wed, 2013-03-20 at 08:32 -0700, Eric Dumazet wrote: > On Wed, 2013-03-20 at 17:33 +0800, tingwei liu wrote: > > From 5d787e8c3725efa6af3036eeb52aba1905c70de9 Mon Sep 17 00:00:00 2001 > > From: root <root@...ux-19.site> > > Date: Wed, 20 Mar 2013 17:39:59 +0800 > > Subject: [PATCH] Change a wrong explain about dev_get_by_name > > > > No changelog ? This patch really needs a changelog. > > I have no idea why we should document this function being not safe in > irq context. > > Most part of networking stack is non safe in hard irq context. > > Should we add a comment in front of all possible entry points ? If they are wrongly documented as 'can be called from any context', yes. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists