netdev - Re: [PATCH] net: add ETH_P_802_3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130321110255.4c06b2b7@redhat.com>
Date:	Thu, 21 Mar 2013 11:02:55 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Simon Horman <horms@...ge.net.au>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Jesse Gross <jesse@...ira.com>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Karsten Keil <isdn@...ux-pingi.de>,
	linux1394-devel@...ts.sourceforge.net, linux-media@...r.kernel.org,
	dev@...nvswitch.org
Subject: Re: [PATCH] net: add ETH_P_802_3_MIN

Em Thu, 21 Mar 2013 17:29:28 +0900
Simon Horman <horms@...ge.net.au> escreveu:

> Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for
> an 802.3 frame. Frames with a lower value in the ethernet type field
> are Ethernet II.
> 
> Also update all the users of this value that I could find to use the
> new constant.
> 
> I anticipate adding some more users of this constant when
> adding MPLS support to Open vSwtich.
> 
> As suggested by Jesse Gross.
> 
> Compile tested only.
> 
> Cc: Jesse Gross <jesse@...ira.com>
> Cc: Stefan Richter <stefanr@...6.in-berlin.de>
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
> Cc: linux1394-devel@...ts.sourceforge.net
> Cc: linux-media@...r.kernel.org
> Cc: dev@...nvswitch.org
> Signed-off-by: Simon Horman <horms@...ge.net.au>

...

> diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
> index 44225b1..9fc82a1 100644
> --- a/drivers/media/dvb-core/dvb_net.c
> +++ b/drivers/media/dvb-core/dvb_net.c
> @@ -185,7 +185,7 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *skb,
>  			skb->pkt_type=PACKET_MULTICAST;
>  	}
>  
> -	if (ntohs(eth->h_proto) >= 1536)
> +	if (ntohs(eth->h_proto) >= ETH_P_802_3_MIN)
>  		return eth->h_proto;

...

Acked-by: Mauro Carvalho Chehab <mchehab@...hat.com>

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html