netdev - Re: [PATCH] net: add ETH_P_802_3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130321.115608.570355867509300023.davem@davemloft.net>
Date:	Thu, 21 Mar 2013 11:56:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	netdev@...r.kernel.org, jesse@...ira.com,
	stefanr@...6.in-berlin.de, isdn@...ux-pingi.de, mchehab@...hat.com,
	linux1394-devel@...ts.sourceforge.net, linux-media@...r.kernel.org,
	dev@...nvswitch.org
Subject: Re: [PATCH] net: add ETH_P_802_3_MIN

From: Simon Horman <horms@...ge.net.au>
Date: Thu, 21 Mar 2013 17:29:28 +0900

> Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for
> an 802.3 frame. Frames with a lower value in the ethernet type field
> are Ethernet II.
> 
> Also update all the users of this value that I could find to use the
> new constant.
> 
> I anticipate adding some more users of this constant when
> adding MPLS support to Open vSwtich.
> 
> As suggested by Jesse Gross.
> 
> Compile tested only.
> 
> Signed-off-by: Simon Horman <horms@...ge.net.au>

You missed a few cases:

drivers/media/dvb-core/dvb_net.c:       } while (p->ule_sndu_type < 1536);
drivers/media/dvb-core/dvb_net.c:                               if (priv->ule_sndu_type < 1536) {
net/atm/lec.h: *    is less than 1536(0x0600) MUST be encoded by placing that length
drivers/net/wireless/ray_cs.c:  if (ntohs(proto) >= 1536) { /* DIX II ethernet frame */
net/bridge/netfilter/ebtables.c:                if (FWINV2(ntohs(ethproto) >= 1536, EBT_IPROTO))
include/linux/if_vlan.h:        if (ntohs(proto) >= 1536) {
net/bluetooth/bnep/netdev.c:    if (proto >= 1536)
net/openvswitch/flow.c: if (ntohs(proto) >= 1536)
net/mac80211/tx.c:      } else if (ethertype >= 0x600) {
net/wireless/util.c:    } else if (ethertype > 0x600) {

In fact, the last line looks like a bug, it should be >= not >.

Could you take care of these bits and respin your patch?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html