netdev - Re: [PATCH] unix: fix a race condition in unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130325.131344.2141703890142351951.davem@davemloft.net>
Date:	Mon, 25 Mar 2013 13:13:44 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pmoore@...hat.com
Cc:	netdev@...r.kernel.org, jan.stancek@...il.com
Subject: Re: [PATCH] unix: fix a race condition in unix_release()

From: Paul Moore <pmoore@...hat.com>
Date: Mon, 25 Mar 2013 09:18:33 -0400

> As reported by Jan, and others over the past few years, there is a
> race condition caused by unix_release setting the sock->sk pointer
> to NULL before properly marking the socket as dead/orphaned.  This
> can cause a problem with the LSM hook security_unix_may_send() if
> there is another socket attempting to write to this partially
> released socket in between when sock->sk is set to NULL and it is
> marked as dead/orphaned.  This patch fixes this by only setting
> sock->sk to NULL after the socket has been marked as dead; I also
> take the opportunity to make unix_release_sock() a void function
> as it only ever returned 0/success.
> 
> Dave, I think this one should go on the -stable pile.
> 
> Special thanks to Jan for coming up with a reproducer for this
> problem.
> 
> Reported-by: Jan Stancek <jan.stancek@...il.com>
> Signed-off-by: Paul Moore <pmoore@...hat.com>

Applied, and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html