netdev - Re: [PATCH net-next] ipv6: don't free static mem in the case of init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130325.131612.839103976133079709.davem@davemloft.net>
Date:	Mon, 25 Mar 2013 13:16:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	honkiko@...il.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next] ipv6: don't free static mem in the case of
 init_net

From: Hong Zhiguo <honkiko@...il.com>
Date: Tue, 26 Mar 2013 00:25:25 +0800

> Signed-off-by: Hong Zhiguo <honkiko@...il.com>

1) This should be submitted against 'net' since it's clearly
   a real bug.

2) This needs to be fixed differently.  We should always
   kmemdup() and create fresh copies of these objects, even
   for init_net.  So 'dflt' and 'all' will start as "NULL"
   and always we will try to kmemdup(&ipv6_defconf, ...) and
   kmemdup(&ipv6_devconf_dflt, ...);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html