netdev - Re: [PATCH] yam: avoid null pointer dereference error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130327.134651.702432728001011428.davem@davemloft.net>
Date:	Wed, 27 Mar 2013 13:46:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	colin.king@...onical.com, jpr@...bb.org,
	linux-hams@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] yam: avoid null pointer dereference error

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 27 Mar 2013 17:44:17 +0000

> On Wed, 2013-03-27 at 11:19 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>> 
>> yam_open checks if dev is null, however, before that check it
>> accesses some of the fields from dev in a proceeding printk which
>> will cause a null pointer dereference error if dev is nul. Move
>> the printk to after the null check.
> 
> This function will never be called with dev == NULL.

Then let's remove at least that part of the check.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html