netdev - Re: [PATCH] yam: avoid null pointer dereference error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5153358A.5010505@canonical.com>
Date:	Wed, 27 Mar 2013 18:08:10 +0000
From:	Colin Ian King <colin.king@...onical.com>
To:	David Miller <davem@...emloft.net>
CC:	bhutchings@...arflare.com, jpr@...bb.org,
	linux-hams@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] yam: avoid null pointer dereference error

On 27/03/13 17:46, David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Wed, 27 Mar 2013 17:44:17 +0000
>
>> On Wed, 2013-03-27 at 11:19 +0000, Colin King wrote:
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> yam_open checks if dev is null, however, before that check it
>>> accesses some of the fields from dev in a proceeding printk which
>>> will cause a null pointer dereference error if dev is nul. Move
>>> the printk to after the null check.
>>
>> This function will never be called with dev == NULL.
>
> Then let's remove at least that part of the check.
>
Good point. How about the following..



View attachment "0001-yam-remove-redundant-null-check-on-dev.patch" of type "text/x-diff" (1135 bytes)