| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <10426929.HS2uObfqRU@sifl> Date: Mon, 08 Apr 2013 14:26:02 -0400 From: Paul Moore <pmoore@...hat.com> To: Eric Dumazet <eric.dumazet@...il.com>, David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, mvadkert@...hat.com Subject: Re: [PATCH] tcp: assign the sock correctly to an outgoing SYNACK packet On Monday, April 08, 2013 11:21:43 AM Eric Dumazet wrote: > On Mon, 2013-04-08 at 14:12 -0400, Paul Moore wrote: > > It seems a bit fragile to me, perhaps even hacky, but in some ways I guess > > it isn't anymore fragile than relying on skb->sk - as this problem > > demonstrates. My other concern is that adding this hook *correctly* is > > likely to touch a lot of files and may be a bit much so late in the 3.9 > > cycle, Dave, what say you? > > I don't get it, 90ba9b1986b5ac4b2d18 was in 3.6, why do you care of > 3.9 ? I wasn't made aware of the particular bug until just recently. When I see a regression I generally try to get it fixed as soon as possible. > I am preparing a fix right now. Not a revert, thank you. I guess we'll have to wait and see then; the more I think about the new hook you proposed the less enthused I am about it. I'm still curious to hear what Dave has to say on this. -- paul moore security and virtualization @ redhat -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists