netdev - Re: [patch net-next] net: squash ->rx_handler and ->rx_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1365438760.25498.21.camel@gandalf.local.home>
Date:	Mon, 08 Apr 2013 12:32:40 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	fubar@...ibm.com, andy@...yhouse.net, kaber@...sh.net,
	stephen@...workplumber.org, jesse@...ira.com,
	alexander.h.duyck@...el.com, xiyou.wangcong@...il.com,
	dev@...nvswitch.org, nicolas.2p.debian@...il.com,
	tglx@...utronix.de, streeter@...hat.com, paulmck@...ibm.com,
	ivecera@...hat.com
Subject: Re: [patch net-next] net: squash ->rx_handler and ->rx_handler_data
 into single rcu pointer

On Sat, 2013-03-30 at 20:32 +0100, Jiri Pirko wrote:

> >This doesn't solve anything. The CPU can be executing func when you set it to null.  Then you have the same problem.  This patch shows you still don't understand the bug.  
> 
> rx_handler->func is never set to NULL and is valid for all rx_handler (port_priv)
> lifetime.
> 

Ah, you're right. I'll look deeper at this patch after reading the
thread.

This is what I get for trying to review a patch reading it on my android
phone ;-)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html