netdev - Re: [PATCH 00/11] usbnet: usbnet: handle link change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5166D431.4080400@iki.fi>
Date:	Thu, 11 Apr 2013 18:18:09 +0300
From:	Jussi Kivilinna <jussi.kivilinna@....fi>
To:	Ming Lei <ming.lei@...onical.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Oliver Neukum <oneukum@...e.de>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 00/11] usbnet: usbnet: handle link change

On 11.04.2013 17:40, Ming Lei wrote:
> Hi,
> 
> This patch set introduces usbnet_link_change() API and applies
> it on all usbnet drivers, then handle the link change centrally
> to stop bulk transfer when link becomes off and restart bulk
> transfer when link becomes on.

Should 'rndis_wlan' be changed to use this too?

-Jussi

> 
> With the change, ~10% performance boost on bulk transfer
> of another device on the same bus can be obtained when link
> is off. Also, stopping bulk transfer when link becomes off
> may disable asynchonous schedule of host controller, power
> might be saved probabally.
> 
>  drivers/net/usb/asix_devices.c |    6 +-----
>  drivers/net/usb/ax88179_178a.c |   12 ++++-------
>  drivers/net/usb/cdc_ether.c    |    5 +----
>  drivers/net/usb/cdc_ncm.c      |    9 +++-----
>  drivers/net/usb/dm9601.c       |    7 +------
>  drivers/net/usb/mcs7830.c      |    6 +-----
>  drivers/net/usb/sierra_net.c   |    3 +--
>  drivers/net/usb/usbnet.c       |   45 +++++++++++++++++++++++++++++++++++++++-
>  include/linux/usb/usbnet.h     |    2 ++
>  9 files changed, 58 insertions(+), 37 deletions(-)
> 
> 
> Thanks,
> --
> Ming Lei
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html