netdev - Re: [PATCH 08/11] usbnet: dm9601: apply usbnet_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zjx5rt8q.fsf@dell.be.48ers.dk>
Date:	Thu, 11 Apr 2013 17:18:13 +0200
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Oliver Neukum <oneukum@...e.de>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 08/11] usbnet: dm9601: apply usbnet_link_change

>>>>> "Ming" == Ming Lei <ming.lei@...onical.com> writes:

 Ming> Use usbnet_link_change to handle link change centrally.

Acked-by: Peter Korsgaard <jacmet@...site.dk>

 Ming> Cc: Peter Korsgaard <jacmet@...site.dk>
 Ming> Signed-off-by: Ming Lei <ming.lei@...onical.com>
 Ming> ---
 Ming>  drivers/net/usb/dm9601.c |    7 +------
 Ming>  1 file changed, 1 insertion(+), 6 deletions(-)

 Ming> diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c
 Ming> index 174e5ec..2dbb946 100644
 Ming> --- a/drivers/net/usb/dm9601.c
 Ming> +++ b/drivers/net/usb/dm9601.c
 Ming> @@ -524,12 +524,7 @@ static void dm9601_status(struct usbnet *dev, struct urb *urb)
 
 Ming>  	link = !!(buf[0] & 0x40);
 Ming>  	if (netif_carrier_ok(dev->net) != link) {
 Ming> -		if (link) {
 Ming> -			netif_carrier_on(dev->net);
 Ming> -			usbnet_defer_kevent (dev, EVENT_LINK_RESET);
 Ming> -		}
 Ming> -		else
 Ming> -			netif_carrier_off(dev->net);
 Ming> +		usbnet_link_change(dev, link, 1);
 Ming>  		netdev_dbg(dev->net, "Link Status is: %d\n", link);
 Ming>  	}
 Ming>  }
 Ming> -- 
 Ming> 1.7.9.5



-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html