netdev - Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k3o8mi17.wl%atzm@stratosphere.co.jp>
Date:	Fri, 12 Apr 2013 14:31:32 +0900
From:	Atzm Watanabe <atzm@...atosphere.co.jp>
To:	David Miller <davem@...emloft.net>
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address.

At Thu, 11 Apr 2013 13:30:14 -0400 (EDT),
David Miller wrote:
> 
> From: Stephen Hemminger <stephen@...workplumber.org>
> Date: Thu, 11 Apr 2013 08:24:38 -0700
> 
> > On Thu, 11 Apr 2013 19:17:54 +0900
> > Atzm Watanabe <atzm@...atosphere.co.jp> wrote:
> > 
> >> diff --git a/include/linux/if_link.h b/include/linux/if_link.h
> >> index 40167af..0bf03dc 100644
> >> --- a/include/linux/if_link.h
> >> +++ b/include/linux/if_link.h
> >> @@ -296,6 +296,7 @@ enum {
> >>  	IFLA_VXLAN_GROUP,
> >>  	IFLA_VXLAN_LINK,
> >>  	IFLA_VXLAN_LOCAL,
> >> +	IFLA_VXLAN_REMOTE,
> >>  	IFLA_VXLAN_TTL,
> >>  	IFLA_VXLAN_TOS,
> > 
> > You can't insert another value into the middle of an enum list.
> > It changes the kernel-userspace ABI values.
> 
> Right.

Thank you for pointing it out.
I'll move IFLA_VXLAN_REMOTE to the last and resend the patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html