netdev - Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ip3smi15.wl%atzm@stratosphere.co.jp>
Date:	Fri, 12 Apr 2013 14:31:34 +0900
From:	Atzm Watanabe <atzm@...atosphere.co.jp>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	<netdev@...r.kernel.org>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 v2] vxlan: Allow setting destination to unicast address.

At Thu, 11 Apr 2013 18:48:20 +0100,
Ben Hutchings wrote:
> 
> On Thu, 2013-04-11 at 19:17 +0900, Atzm Watanabe wrote:
> > This patch allows setting VXLAN destination to unicast address.
> > It allows that VXLAN can be used as peer-to-peer tunnel without
> > multicast.
> > 
> > v2: use a new argument "remote" instead of "group" based by
> >     Stephen Hemminger's comments.
> > 
> > Signed-off-by: Atzm Watanabe <atzm@...atosphere.co.jp>
> [...]
> > --- a/ip/iplink_vxlan.c
> > +++ b/ip/iplink_vxlan.c
> > @@ -23,7 +23,8 @@
> >  
> >  static void explain(void)
> >  {
> > -	fprintf(stderr, "Usage: ... vxlan id VNI [ group ADDR ] [ local ADDR ]\n");
> > +	fprintf(stderr, "Usage: ... vxlan id VNI [ group ADDR ] [ remote ADDR ]\n");
> [...]
> 
> Shouldn't that be "[ group|remote ADDR ]", to show that you can specify
> one or the other?

Yes, basically I agreed.
I think this should be "[ { group | remote } ADDR ]",
to accommodate the notation to others.
I'll fix this and resend the patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html