netdev - Re: [PATCH net-next] vxlan: don't bypass encapsulation for multi- and broadcasts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130415.014530.1175856229390286987.davem@davemloft.net>
Date:	Mon, 15 Apr 2013 01:45:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mike.rapoport@...ellosystems.com
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next] vxlan: don't bypass encapsulation for multi-
 and broadcasts

From: Mike Rapoport <mike.rapoport@...ellosystems.com>
Date: Mon, 15 Apr 2013 08:31:15 +0300

> On Sun, Apr 14, 2013 at 10:39 PM, David Miller <davem@...emloft.net> wrote:
>> From: Mike Rapoport <mike.rapoport@...ellosystems.com>
>> Date: Sun, 14 Apr 2013 12:21:51 +0300
>>
>>> The multicast and broadcast packets may have RTCF_LOCAL set in rt_flags
>>> and therefore will be sent out bypassing encapsulation. This breaks
>>> delivery of packets sent to the vxlan multicast group.
>>> Disabling encapsulation bypass for multicasts and broadcasts fixes the
>>> issue.
>>>
>>> Signed-off-by: Mike Rapoport <mike.rapoport@...ellosystems.com>
>>
>> This still won't handle the case of encapsulations occuring in different
>> namespaces or virtual machines.
>>
>> I really want this fixed correctly.
> 
> I'm sorry, but I don't quite follow you. The patch does not aim to
> reduce the amount of encapsulation. On the contrary, it prevents some
> packets from being encapsulated when they should not be...

I'm saying you need to make sure the bypass is avoided in these
situations as well.

There is an ongoing discussion about this on the list between Cong
Wang and the author of the bypass changes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html