netdev - RE: [net PATCH] be2net: take care of __vlan_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b9ba2cb-c3b1-477e-8e39-4e2f36700dec@CMEXHTCAS2.ad.emulex.com>
Date:	Mon, 15 Apr 2013 06:13:37 +0000
From:	"Perla, Sathya" <Sathya.Perla@...lex.Com>
To:	David Miller <davem@...emloft.net>,
	"ivecera@...hat.com" <ivecera@...hat.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Seetharaman, Subramanian" <subbu.seetharaman@...lex.com>,
	"Khaparde, Ajit" <Ajit.Khaparde@...lex.Com>
Subject: RE: [net PATCH] be2net: take care of __vlan_put_tag return value

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> 
> From: Ivan Vecera <ivecera@...hat.com>
> 
> I'll apply this patch but there is some strangeness with the logic that controls
> these code paths.
> 
> The call to be_insert_vlan_in_pkt() is guarded by:
> 
> 	be_vlan_tag_chk(adapter, skb)
> 
> which evaluates to:
> 
> 	vlan_tx_tag_present(skb) || adapter->pvid
> 
> But the __vlan_put_tag() call is guarded by only one of those two
> conditions:
> 
> 	vlan_tx_tag_present(skb)
> 
> One of these two is wrong and should be corrected.

David, yes the pvid check here is wrong.

The pvid insertion by the driver (to hack around some HW bugs) requires some support from the FW and that
requires some more code/logic. That fix seems to be missing in the netdev tree.

We'll send out a patch-set to handle these issues. Thanks!

-Sathya
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html