netdev - Re: [PATCH] pkt_sched: fix error return code in fw_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516FF3D2.7070402@mojatatu.com>
Date:	Thu, 18 Apr 2013 09:23:30 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	davem@...emloft.net, yongjun_wei@...ndmicro.com.cn,
	netdev@...r.kernel.org
Subject: Re: [PATCH] pkt_sched: fix error return code in fw_change_attrs()

On 13-04-17 10:49 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Fix to return -EINVAL when tb[TCA_FW_MASK] is set and head->mask != 0xFFFFFFFF
> instead of 0 (ifdef CONFIG_NET_CLS_IND and tb[TCA_FW_INDEV]), as done elsewhere
> in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>


Makes sense.  I think i would have said something like:
"dont use the err code from tcf_change_indev() in case it succeeds to 
report TCA_FW_MASK errors"

Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html