netdev - Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130422.154423.1695741341535269869.davem@davemloft.net>
Date:	Mon, 22 Apr 2013 15:44:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	gang.chen@...anux.com
Cc:	pshelar@...ira.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

From: Chen Gang <gang.chen@...anux.com>
Date: Mon, 22 Apr 2013 18:17:21 +0800

>   need remove erroneous semicolon.
> 
>   the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
> 
>   Find it by EXTRA_CFLAGS=-W
> 
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>

First, what is a "type issue", you aren't changing any variable
or declaration types in this change.

Second, your formatting of your commit messages is terrible.

Do not indent the description with two spaces, just keep them at the
leftmost column.  Where did you learn to indent things like that, who
else does that?  If you've never seen it before, don't invent things.

It is very irritating when we see people write commit messages with
their own style rather than mimicking what other successful
contributors are doing.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html