netdev - Re: [PATCH -next] net: avoid inet dependency on aes crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1366660210.4016.11.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 22 Apr 2013 20:50:10 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	<fw@...len.de>, <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] net: avoid inet dependency on aes crypto

On Mon, 2013-04-22 at 15:25 -0400, David Miller wrote:
> From: Florian Westphal <fw@...len.de>
> Date: Mon, 22 Apr 2013 15:30:03 +0200
> 
> > commit 798b2cbf9227b1bd7d37ae9af4d9c750e6f4de9c
> > (net: Add INET dependency on aes crypto for the sake of TCP fastopen.)
> > results in aes-asm module no longer being loaded when AES cipher is
> > requested, due to CRYPTO_AES=y.
> > 
> > However, there is no link-time dependency on aes. Drop dep and instead
> > set "default m" for aes crypto if inet is enabled.
> > 
> > Signed-off-by: Florian Westphal <fw@...len.de>
> 
> This is terrible on so many levels.
> 
> If the assembler versions of the AES module can't be loaded properly
> when AES is built statically into the kernel, don't work around it,
> fix it instead.

On x86 the appropriate optimised aes implementation should still be
loaded based on an 'x86cpu' alias.  I don't know whether it will end up
being used.

It doesn't look like anything similar has been done for other
architectures yet, but that is probably the way to go.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html