netdev - [PATCH] remove vlan tags in CPSW dual emac mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4699400.vD3TdgH1nR@localhost>
Date:	Tue, 23 Apr 2013 18:18:47 +0200
From:	Markus Brunner <systemprogrammierung.brunner@...il.com>
To:	netdev@...r.kernel.org, Mugunthan V N <mugunthanvnm@...com>
Cc:	davem@...emloft.net, linux-arm-kernel@...ts.infradead.org,
	linux-omap@...r.kernel.org, Mark Jackson <mpfj-list@...flow.co.uk>,
	systemprogrammierung.brunner@...il.com
Subject: [PATCH] remove vlan tags in CPSW dual emac mode

If operating in dual emac mode all packets sent by the CPSW contain vlan headers with the reserved VID 0, 
which gets stripped away by all somewhat recent Linux versions. Operating systems without that behaviour will fail to communicate. 
This patch fixes that behaviour by disabling the VLAN_AWARE mode as already described by the comment above.

Signed-off-by: Markus Brunner <systemprogrammierung.brunner@...il.com>
Tested-by: Mark Jackson <mpfj@...flow.co.uk>

---
--- linux-3.9-rc8.orig/drivers/net/ethernet/ti/cpsw.c	2013-04-23 17:26:11.000000000 +0200
+++ linux-3.9-rc8/drivers/net/ethernet/ti/cpsw.c	2013-04-23 17:36:25.000000000 +0200
@@ -751,9 +751,9 @@ static void cpsw_init_host_port(struct c
 	/* switch to vlan unaware mode */
 	cpsw_ale_control_set(priv->ale, priv->host_port, ALE_VLAN_AWARE,
 			     CPSW_ALE_VLAN_AWARE);
 	control_reg = readl(&priv->regs->control);
-	control_reg |= CPSW_VLAN_AWARE;
+	control_reg &= ~CPSW_VLAN_AWARE;
 	writel(control_reg, &priv->regs->control);
 	fifo_mode = (priv->data.dual_emac) ? CPSW_FIFO_DUAL_MAC_MODE :
 		     CPSW_FIFO_NORMAL_MODE;
 	writel(fifo_mode, &priv->host_port_regs->tx_in_ctl);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html