netdev - Re: [PATCH] remove vlan tags in CPSW dual emac mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5176C4FE.4080305@ti.com>
Date:	Tue, 23 Apr 2013 22:59:34 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Markus Brunner <systemprogrammierung.brunner@...il.com>
CC:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>,
	Mark Jackson <mpfj-list@...flow.co.uk>
Subject: Re: [PATCH] remove vlan tags in CPSW dual emac mode

On 4/23/2013 9:48 PM, Markus Brunner wrote:
> If operating in dual emac mode all packets sent by the CPSW contain vlan headers with the reserved VID 0,
> which gets stripped away by all somewhat recent Linux versions. Operating systems without that behaviour will fail to communicate.
> This patch fixes that behaviour by disabling the VLAN_AWARE mode as already described by the comment above.
>
> Signed-off-by: Markus Brunner <systemprogrammierung.brunner@...il.com>
> Tested-by: Mark Jackson <mpfj@...flow.co.uk>
>
> ---
> --- linux-3.9-rc8.orig/drivers/net/ethernet/ti/cpsw.c	2013-04-23 17:26:11.000000000 +0200
> +++ linux-3.9-rc8/drivers/net/ethernet/ti/cpsw.c	2013-04-23 17:36:25.000000000 +0200
> @@ -751,9 +751,9 @@ static void cpsw_init_host_port(struct c
>   	/* switch to vlan unaware mode */
>   	cpsw_ale_control_set(priv->ale, priv->host_port, ALE_VLAN_AWARE,
>   			     CPSW_ALE_VLAN_AWARE);
>   	control_reg = readl(&priv->regs->control);
> -	control_reg |= CPSW_VLAN_AWARE;
> +	control_reg &= ~CPSW_VLAN_AWARE;
>   	writel(control_reg, &priv->regs->control);
>   	fifo_mode = (priv->data.dual_emac) ? CPSW_FIFO_DUAL_MAC_MODE :
>   		     CPSW_FIFO_NORMAL_MODE;
>   	writel(fifo_mode, &priv->host_port_regs->tx_in_ctl);
Disabling VLAN aware mode will enable switching mode and the feature of
separating the two down stream port is lost with this patch
Please check TRM for more info in *14.3.2.10.2 Dual Mac Mode* chapter

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html