netdev - Re: [PATCH net-next] net: fix address check in rtnl_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130423.182922.1691641134127453781.davem@davemloft.net>
Date:	Tue, 23 Apr 2013 18:29:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vyasevic@...hat.com
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org,
	dlstevens@...ibm.com
Subject: Re: [PATCH net-next] net: fix address check in rtnl_fdb_del

From: Vlad Yasevich <vyasevic@...hat.com>
Date: Tue, 23 Apr 2013 17:04:46 -0400

> On 04/23/2013 04:47 PM, Ben Hutchings wrote:
>> On Tue, 2013-04-23 at 16:39 -0400, Vlad Yasevich wrote:
>>> @@ -2192,7 +2192,7 @@ static int rtnl_fdb_del(struct sk_buff *skb,
>>> struct nlmsghdr *nlh)
>>>   	}
>>>
>>>   	addr = nla_data(tb[NDA_LLADDR]);
>>> -	if (!is_valid_ether_addr(addr)) {
>>> +	if (!is_zero_ether_addr(addr)) {
>>
>> This is the opposite of what you want.
> 
> of course you are right....  totally forgot the '!'...

Please test your patches.

If this patch is so unimportant that you don't feel inclined to test
it, it's probably not important enough for me to apply either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html