netdev - Re: [PATCHv2 net-next] net: fix address check in rtnl_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130423.183037.831300005006610868.davem@davemloft.net>
Date:	Tue, 23 Apr 2013 18:30:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vyasevic@...hat.com
Cc:	netdev@...r.kernel.org, dlstevens@...ibm.com
Subject: Re: [PATCHv2 net-next] net: fix address check in rtnl_fdb_del

From: Vlad Yasevich <vyasevic@...hat.com>
Date: Tue, 23 Apr 2013 17:05:23 -0400

> Commit 6681712d67eef14c4ce793561c3231659153a320
> 	vxlan: generalize forwarding tables
> 
> relaxed the address checks in rtnl_fdb_del() to use is_zero_ether_addr().
> This allows users to add multicast addresses using the fdb API.  However,
> the check in rtnl_fdb_del() still uses a more strict
> is_valid_ether_addr() which rejects multicast addresses.  Thus it
> is possible to add an fdb that can not be later removed.
> Relax the check in rtnl_fdb_del() as well.
> 
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>

I don't think you were able to actually test this patch in the
amount of time between when the bug in your initial version was
shown to you and when you posted this new version.

If you indeed didn't test this patch, I really don't think that's
acceptable, to be honest with you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html