netdev - Re: [PATCH] GRE: Use IS_ERR_OR_NULL in gre_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130425091151.GA27681@gondor.apana.org.au>
Date:	Thu, 25 Apr 2013 17:11:51 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	jesse@...ira.com, horms@...ge.net.au, eric.dumazet@...il.com,
	netdev@...r.kernel.org, xeb@...l.ru
Subject: Re: [PATCH] GRE: Use IS_ERR_OR_NULL in gre_gso_segment

On Thu, Apr 25, 2013 at 05:03:46PM +0800, Herbert Xu wrote:
> On Thu, Apr 25, 2013 at 05:01:57AM -0400, David Miller wrote:
> > From: Herbert Xu <herbert@...dor.apana.org.au>
> > Date: Thu, 25 Apr 2013 16:46:17 +0800
> > 
> > > Perhaps add an wrapper for the IS_ERR_OR_NULL with a descriptive
> > > name?
> > 
> > Or pick an error code for the case covered by NULL.
> 
> Picking an error code may create a maintainence problem down the
> track because the same error code could be reused by something
> deeper down in the GSO stack.

In any case, returning an error in this case makes little sense
because when we return NULL it is precisely because the packet is
well-formed and ready for direct processing by the hardware which
will perform GSO instead of us.

The reason this dichotomy exists is because we've reused the
normal software GSO path to do header verification for hardware
GSO.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html