netdev - Re: [PATCH net-next 5/7] qlcnic: Rename the IRQ description.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130425.192152.930991447232787505.davem@davemloft.net>
Date:	Thu, 25 Apr 2013 19:21:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jitendra.kalsaria@...gic.com
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org,
	sony.chacko@...gic.com, shahed.shaikh@...gic.com,
	Dept_NX_Linux_NIC_Driver@...gic.com, himanshu.madhani@...gic.com
Subject: Re: [PATCH net-next 5/7] qlcnic: Rename the IRQ description.

From: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Date: Thu, 25 Apr 2013 23:11:05 +0000

> We will like to add the qlcnic prefix to the above format, as it makes it
> easier for an end user to identify which driver these entries belongs to,
> without having to run addition command.

This is illogical, and wrong.

By being different, you are making it MORE DIFFICULT for users because
they have to specially accomodate your unique conventions.

Please follow what other drivers do.

If you disagree with what the convention is, start a discussion about
changing it, rather than doing whatever you feel like doing in your
drivers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html