netdev - Re: [PATCH net-next 5/7] qlcnic: Rename the IRQ description.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BECD8E8A1B550B48A1BF97C13991F60E2FFCEB@avmb2.qlogic.org>
Date:	Fri, 26 Apr 2013 00:35:25 +0000
From:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
To:	David Miller <davem@...emloft.net>
CC:	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	netdev <netdev@...r.kernel.org>,
	Sony Chacko <sony.chacko@...gic.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>,
	Himanshu Madhani <himanshu.madhani@...gic.com>
Subject: Re: [PATCH net-next 5/7] qlcnic: Rename the IRQ description.



On 4/25/13 4:21 PM, "David Miller" <davem@...emloft.net> wrote:

>From: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
>Date: Thu, 25 Apr 2013 23:11:05 +0000
>
>> We will like to add the qlcnic prefix to the above format, as it makes
>>it
>> easier for an end user to identify which driver these entries belongs
>>to,
>> without having to run addition command.
>
>This is illogical, and wrong.
>
>By being different, you are making it MORE DIFFICULT for users because
>they have to specially accomodate your unique conventions.
>
>Please follow what other drivers do.
>
>If you disagree with what the convention is, start a discussion about
>changing it, rather than doing whatever you feel like doing in your
>drivers.

We will follow the convention and make the changes in a future submission.


Thanks,
    Jiten


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html