netdev - Re: [PATCH net 6/7] qlcnic: Fix reset recovery after transmit timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Apr 2013 22:01:01 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Shahed Shaikh <shahed.shaikh@...gic.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<Dept_NX_Linux_NIC_Driver@...gic.com>,
	Sony Chacko <sony.chacko@...gic.com>
Subject: Re: [PATCH net 6/7] qlcnic: Fix reset recovery after transmit
 timeout

On Fri, 2013-04-26 at 08:09 -0400, Shahed Shaikh wrote:
> From: Sony Chacko <sony.chacko@...gic.com>
> 
> o When transmit timeout happens, recovery attempt should start with
>   adapter soft reset. If soft reset fails to resume traffic, firmware
>   dump will be collected and driver will perform a hard reset of the
>   adapter. Reset recovery on 83xx was failing after a hard reset.
>   This patch fixes that issue.
> 
> Signed-off-by: Sony Chacko <sony.chacko@...gic.com>
> Signed-off-by: Shahed Shaikh <shahed.shaikh@...gic.com>
> ---
>  .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c  |   24 ++++++++++++-------
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |   15 ++++++++----
>  2 files changed, 25 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
> index 5c033f2..7b103d1 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
> @@ -406,10 +406,7 @@ static void qlcnic_83xx_idc_attach_driver(struct qlcnic_adapter *adapter)
>  	}
>  done:
>  	netif_device_attach(netdev);
> -	if (netif_running(netdev)) {
> -		netif_carrier_on(netdev);
> -		netif_wake_queue(netdev);
> -	}
> +	adapter->netdev->trans_start = jiffies;
>  }
[...]

The deletions look good, but it should not be necessary to write to
trans_start.  Why do you think it is needed?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html