lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Apr 2013 19:08:50 +0000 From: Shahed Shaikh <shahed.shaikh@...gic.com> To: Ben Hutchings <bhutchings@...arflare.com> CC: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Dept-NX Linux NIC Driver <Dept_NX_Linux_NIC_Driver@...gic.com>, Sony Chacko <sony.chacko@...gic.com> Subject: RE: [PATCH net 6/7] qlcnic: Fix reset recovery after transmit timeout > From: Ben Hutchings [mailto:bhutchings@...arflare.com] > Sent: Saturday, April 27, 2013 2:31 AM > To: Shahed Shaikh > Cc: David Miller; netdev; Dept-NX Linux NIC Driver; Sony Chacko > Subject: Re: [PATCH net 6/7] qlcnic: Fix reset recovery after transmit timeout > [...] > > netif_device_attach(netdev); > > - if (netif_running(netdev)) { > > - netif_carrier_on(netdev); > > - netif_wake_queue(netdev); > > - } > > + adapter->netdev->trans_start = jiffies; > > } > [...] > > The deletions look good, but it should not be necessary to write to > trans_start. Why do you think it is needed? You are correct, we don't have to update netdev->trans_start. We were updating netdev->trans_start to prevent watchdog from kicking in. Watchdog timeout will not happen because we are waking the Tx queue and turning the carrier ON prior to attaching the device. We will make the required change as you suggested in V2 of the patch series. Thanks, Shahed > > Ben. > > -- > Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; > that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. >
Powered by blists - more mailing lists