netdev - Re: [PATCH] GRE: Use IS_ERR_OR_NULL in gre_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Apr 2013 11:38:33 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, jesse@...ira.com,
	horms@...ge.net.au, netdev@...r.kernel.org, xeb@...l.ru
Subject: Re: [PATCH] GRE: Use IS_ERR_OR_NULL in gre_gso_segment

On Thu, Apr 25, 2013 at 06:58:34AM -0700, Eric Dumazet wrote:
> On Thu, 2013-04-25 at 17:11 +0800, Herbert Xu wrote:
> 
> > In any case, returning an error in this case makes little sense
> > because when we return NULL it is precisely because the packet is
> > well-formed and ready for direct processing by the hardware which
> > will perform GSO instead of us.
> > 
> > The reason this dichotomy exists is because we've reused the
> > normal software GSO path to do header verification for hardware
> > GSO.
> > 
> 
> OK, then current code is fine. Comments will save future 'cleanups'.

Looks good to me.  Either this or add a wrapper so that the comments
don't get out-of-sync since this construct is used in multiple
places.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html