[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B720F@saturn3.aculab.com>
Date: Tue, 30 Apr 2013 09:49:21 +0100
From: "David Laight" <David.Laight@...LAB.COM>
To: "Pablo Neira Ayuso" <pablo@...filter.org>,
<netfilter-devel@...r.kernel.org>
Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: RE: [PATCH 04/18] netfilter: ipset: Unified bitmap type generation
> +++ b/net/netfilter/ipset/ip_set_bitmap_gen.h
> @@ -0,0 +1,265 @@
...
> +#define CONCAT(a, b) a##b
> +#define TOKEN(a,b) CONCAT(a, b)
> +
> +#define mtype_do_test TOKEN(MTYPE, _do_test)
> +#define mtype_gc_test TOKEN(MTYPE, _gc_test)
...
> +#define mtype MTYPE
I'm not entirely sure what is being achieved by the above.
Either there ought to be a comment about what MTYPE might
be set to, or it is all pointless.
In any case names like CONCAT() and TOKEN() are likely
to be double definitions.
A similar namespace issue arises with REVISION_MIN/MAX.
David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists