netdev - RE: [PATCH 04/18] netfilter: ipset: Unified bitmap type generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1304301058540.20765@blackhole.kfki.hu>
Date:	Tue, 30 Apr 2013 11:19:31 +0200 (CEST)
From:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
To:	David Laight <David.Laight@...LAB.COM>
cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	netfilter-devel@...r.kernel.org,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: RE: [PATCH 04/18] netfilter: ipset: Unified bitmap type generation

On Tue, 30 Apr 2013, David Laight wrote:

> > +++ b/net/netfilter/ipset/ip_set_bitmap_gen.h
> > @@ -0,0 +1,265 @@
> ...
> > +#define CONCAT(a, b)		a##b
> > +#define TOKEN(a,b)		CONCAT(a, b)
> > +
> > +#define mtype_do_test		TOKEN(MTYPE, _do_test)
> > +#define mtype_gc_test		TOKEN(MTYPE, _gc_test)
> ...
> > +#define mtype			MTYPE
> 
> I'm not entirely sure what is being achieved by the above.
> Either there ought to be a comment about what MTYPE might
> be set to, or it is all pointless.

mtype is defined in order to SHOUT less in the code later.
 
> In any case names like CONCAT() and TOKEN() are likely
> to be double definitions.
>
> A similar namespace issue arises with REVISION_MIN/MAX.

I'll send a patch with more speficic names.

Best regards,
Jozsef
-
E-mail  : kadlec@...ckhole.kfki.hu, kadlecsik.jozsef@...ner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html