netdev - Re: [PATCH net-next] filter: fix va

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51818350.6040600@redhat.com>
Date:	Wed, 01 May 2013 23:04:16 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Xi Wang <xi.wang@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] filter: fix va_list build error

On 05/01/2013 10:24 PM, Xi Wang wrote:
> This patch fixes the following build error.
>
> In file included from include/linux/filter.h:52:0,
>                   from arch/arm/net/bpf_jit_32.c:14:
> include/linux/printk.h:54:2: error: unknown type name ‘va_list’
> include/linux/printk.h:105:21: error: unknown type name ‘va_list’
> include/linux/printk.h:108:30: error: unknown type name ‘va_list’
>
> Signed-off-by: Xi Wang <xi.wang@...il.com>
> ---
>   include/linux/filter.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index d1248f4..c050dcc 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -48,6 +48,7 @@ extern int sk_chk_filter(struct sock_filter *filter, unsigned int flen);
>   extern int sk_get_filter(struct sock *sk, struct sock_filter __user *filter, unsigned len);
>
>   #ifdef CONFIG_BPF_JIT
> +#include <stdarg.h>
>   #include <linux/linkage.h>
>   #include <linux/printk.h>

That's a bit weird. Xi, maybe in a follow-up some time later, could
you move the GCC-internal stdarg.h rather into linux/printk.h, since
that's where the problem is coming from? Imho, it might be better off
there, no?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html